search

kubernetes-sigs / sig-windows-dev-tools

This is a batteries included local development environment for Kubernetes on Windows.
Apache License 2.0
80 stars 46 forks source link

Add Magefiles as port of Makefile functionality #259

Closed mloskot closed 1 year ago

mloskot commented 1 year ago

Disclaimer: I've never written any Go before and this is my first attempt ever to write some. Please, don't spare me your criticism.

This is first multi-platform stab at the idea of the true Windows support in #203

This Mage port of the current Makefile which is supposed to offer equivalent functionality as the existing Makefile. The Magefiles implementation is also inspired by the make.ps1 recently proposed in #254.

The initial reaction to the #254 suggested the Magefiles are preferred as a single multi-platform solution. So, if the Magefiles are accepted, then this PR should completely replace the make.ps1 proposal in #254.

The Magefiles currently deploy Kubernetes from downloaded binaries, because on Windows building from sources is not yet solved, see #255. On Linux host, Kubernetes can be built from sources and this option will be added to these Magefiles in near future. First, let's get this solution working solid from the pre-built binaries.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mloskot Once this PR has been reviewed and has the lgtm label, please assign knabben for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/sig-windows-dev-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mloskot commented 1 year ago

I've converted this PR to draft. Let's get the Vagrant box working solid first as per @jayunit100 suggestion at last SIG-Windows meeting.

pellared commented 1 year ago

I encourage also take a look at https://github.com/goyek/goyek

mloskot commented 1 year ago

Replaced by #264 aka master-nowsl branch.