search

kubernetes-sigs / sig-windows-dev-tools

This is a batteries included local development environment for Kubernetes on Windows.
Apache License 2.0
80 stars 46 forks source link

Address issues raised in #264 post-merge review #268

Closed mloskot closed 1 year ago

mloskot commented 1 year ago

This PR includes a bunch of corrections addressing issues raised by @claudiubelu in post-merge review of PR #264 Thank you Claudiu!

/cc @jayunit100

jayunit100 commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayunit100, mloskot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-dev-tools/blob/master-windows-native/OWNERS)~~ [jayunit100] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
claudiubelu commented 1 year ago

LGTM!