kubernetes-sigs / sig-windows-dev-tools

This is a batteries included local development environment for Kubernetes on Windows.
Apache License 2.0
80 stars 46 forks source link

Updated vagrantfile with winrm and smb specific configurations. #274

Closed KrishAmal closed 1 year ago

KrishAmal commented 1 year ago

Added and modified few lines in the vagrantfile, which

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 year ago

Welcome @KrishAmal!

It looks like this is your first PR to kubernetes-sigs/sig-windows-dev-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-windows-dev-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

jayunit100 commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayunit100, KrishAmal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-dev-tools/blob/master-qemu/OWNERS)~~ [jayunit100] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jayunit100 commented 1 year ago

This is a huge amount of work amal has been experimenting on over the past few weeks really great to see it all come together

Thank you amal!

Now others can try to get up to speed with this qemu effort and maybe we can get it to he the 2nd provider officially some day

jayunit100 commented 1 year ago

Merged since it's a Dev branch. Maybe we can try integrating w mage if we get a working cluster on it