search

kubernetes-sigs / sig-windows-dev-tools

This is a batteries included local development environment for Kubernetes on Windows.
Apache License 2.0
80 stars 46 forks source link

fix(cli): Execute PowerShell command via SSH as oneliner #280

Closed mloskot closed 10 months ago

mloskot commented 10 months ago

Apparently, ssh.Session trips over newline characters while executing the multiline command on the remote Windows host with PowerShell. Only command in first line is executed.

Replacing newline character with ; as no-op.

Running the swdt-cli in PowerShell 7 on Windows host:

image

image

knabben commented 10 months ago

/lgtm /approve

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knabben, mloskot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-dev-tools/blob/master/OWNERS)~~ [knabben] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment