search

kubernetes-sigs / sig-windows-dev-tools

This is a batteries included local development environment for Kubernetes on Windows.
Apache License 2.0
80 stars 46 forks source link

refactor(cli): Rename API type Config to Node #283

Closed mloskot closed 10 months ago

mloskot commented 10 months ago

Since the Config schema described configuration of a single node, its type name should reflect the purpose.

Preliminary approval of a better name was expressed by @knabben in this comment of

mloskot commented 10 months ago

/cc @knabben

knabben commented 10 months ago

/lgtm /approve

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knabben, mloskot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-dev-tools/blob/master/OWNERS)~~ [knabben] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment