search

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
126 stars 123 forks source link

Adding a GH action to ensure we have build all versions of Windows kube-proxy image #243

Closed marosset closed 2 years ago

marosset commented 2 years ago

Signed-off-by: Mark Rossetti marosset@microsoft.com

Reason for PR:

Adding a github action to ensure we have build Windows kube-proxy images for all applicable K8s versions.

I have this running in my fork and it is correctly failing b/c of missing v1.22.0 images

Issue Fixed:

Issue #

Requirements

Notes:

/assign @jsturtevant @fabi200123

k8s-ci-robot commented 2 years ago

@marosset: GitHub didn't allow me to assign the following users: fabi200123.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/sig-windows-tools/pull/243): > > >Signed-off-by: Mark Rossetti > >**Reason for PR**: > >Adding a github action to ensure we have build Windows kube-proxy images for all applicable K8s versions. > >I have this running in my fork and it is correctly failing b/c of missing v1.22.0 images > >**Issue Fixed**: > >Issue # > >**Requirements** > >- [ ] Sqaush commits >- [ ] Documentation >- [ ] Tests > >**Notes**: > >/assign @jsturtevant @fabi200123 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)~~ [marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
marosset commented 2 years ago

Run in my fork https://github.com/marosset/sig-windows-tools/runs/8216272669?check_suite_focus=true

jsturtevant commented 2 years ago

/lgtm