kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
126 stars 123 forks source link

Remove diskutil as it was moved to csi-proxy #273

Closed jsturtevant closed 1 year ago

jsturtevant commented 1 year ago

Signed-off-by: James Sturtevant jstur@microsoft.com

Reason for PR:

This logic was ported over to csi-proxy: https://github.com/kubernetes-csi/csi-proxy/blob/master/pkg/os/disk/api.go#L190 and is no longer needed here.

Issue Fixed:

Issue #

Requirements

Notes:

discussed in slack: https://kubernetes.slack.com/archives/CN5JCCW31/p1672169267353319

jsturtevant commented 1 year ago

/assign @ddebroy @marosset

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddebroy, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)~~ [ddebroy,jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment