Correct vxlan settings in guide

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.

Apache License 2.0

126 stars 123 forks source link

Correct vxlan settings in guide #301

Closed UweErikMartin closed 1 year ago

UweErikMartin commented 1 year ago

Correction in section 5 - Apply kube-flannel-rbac.yml from sig-windows-tools/kubeadm/flannel

The file kube-flannel-rbac.yml contains also a net-conf.json section which must also contain the VNI (4096) and the Port (4789). Added an sed-command to apply those changes during installation.

linux-foundation-easycla[bot] commented 1 year ago

:x: The commit (f0487def315349c5450da9adfd394586942d0719, 7e1fb610153fc443a4da1e116692d9ee48bf792f). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: UweErikMartin Once this PR has been reviewed and has the lgtm label, please assign jsturtevant for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

k8s-ci-robot commented 1 year ago

Welcome @UweErikMartin!

It looks like this is your first PR to kubernetes-sigs/sig-windows-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-windows-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

UweErikMartin commented 1 year ago

Reopen pull request after signing CLA