Correct vxlan in guide - Githubissues

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.

Apache License 2.0

126 stars 123 forks source link

Correct vxlan in guide #303

Closed UweErikMartin closed 1 year ago

UweErikMartin commented 1 year ago

The installation guide describes in chapter 5 how to apply kube-flannel-rbac.yml to the windows node. The corresponding yml file does not contain the correct vxlan configuration using VNI: 4096 and Port: 4789. The guide description was changed to inject the correct vxlan settings during the kubectl apply command.

linux-foundation-easycla[bot] commented 1 year ago

:white_check_mark: login: UweErikMartin (0b7b7598c95c087e0e0f8e140f34d7a1d31bda56, 3f262653e01a3ddb0efab238e6e9ddb52978dc21, 4d273093cb7a6aa1f2c10d647c092d75c2f30402, 9ddf22598fa5323b54c2c4fb994fb85f00da3e20, 1f14ba6422378ff867e9cfa45fbfc714ef4db4eb, 67d40ae0ddca78c41e6d53e650d5f155a5fd6a2f, 076c72b72d3405f270cb7997ab4b35ba3d8d0a2f, 09521a8372b673a75a66a7ec70d39d889d8d246a, 2f094d5956e99ab5c853009f5924d5190bb76cfb, 707d74e154a08126ac9bda5ff142113384a31be3, 2ab15223a0b326d98ae024cd36285e1413d6d3ec, 16aa0384fe7d5a4869988c7748bcebf364fac761, 52b48284b8e7076c77a072188bb16f1aa8eed03c)
:x: The commit (f0487def315349c5450da9adfd394586942d0719, 697a097f98908ea8230695a22b7a420bd5c95cd8). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: UweErikMartin Once this PR has been reviewed and has the lgtm label, please assign jayunit100 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

claudiubelu commented 1 year ago

It seems you're still missing the CLA. Make sure that the commits have the same email as the one you've signed the CLA with. Also, could you squash the 2 commits?

UweErikMartin commented 1 year ago

CLA for individual contributor is signed and same email and username as the last "squashed" commit is used in CLA. What to do to get it accepted by the robot? Am I missing something? Does it take time to be recognized by the system?

jsturtevant commented 1 year ago

you can bot commands in the list of commands /check-cla

jsturtevant commented 1 year ago

@UweErikMartin Doesn't look like the check worked. You may need to contact support (https://github.com/kubernetes-sigs/sig-windows-tools/pull/303#issuecomment-1538737509)

molssongroup commented 1 year ago

/easycla

UweErikMartin commented 1 year ago

/easycla

marosset commented 1 year ago

/checkcla

marosset commented 1 year ago

/check-cla

UweErikMartin commented 1 year ago

I'm puzzled.... updated my last commit using git commit --amend --author="UweErikMartin uwe_erik_martin@yahoo.de" --no-edit and pushed.... the ID is now the user ID of github... what is wrong?

UweErikMartin commented 1 year ago

/check-cla

UweErikMartin commented 1 year ago

/easycla

UweErikMartin commented 1 year ago

lets close this and open the pull-request from scratch