Closed UweErikMartin closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: UweErikMartin Once this PR has been reviewed and has the lgtm label, please assign aravindhp for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
It looks like the first few commits are missing info:
❌ The commit (https://github.com/kubernetes-sigs/sig-windows-tools/commit/f0487def315349c5450da9adfd394586942d0719, https://github.com/kubernetes-sigs/sig-windows-tools/commit/697a097f98908ea8230695a22b7a420bd5c95cd8). This user is missing the User's ID, preventing the EasyCLA check. [Consult GitHub Help](https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user) to resolve.For further assistance with EasyCLA, [please submit a support request ticket](https://jira.linuxfoundation.org/servicedesk/customer/portal/4).
Maybe if you sqaush the commits, drop them or start fresh it might help? The latest commits seems to have the correct info
/check-cla
I start from scratch
The cni-conf.json configmap in kube-flannel-rbac.yml does not contain the VNI and Port required for windows vxlan communication. This is added.