kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
126 stars 123 forks source link

add vni and port to cni-conf.json in kube-flannel-rbac.yml #305

Closed UweErikMartin closed 1 year ago

UweErikMartin commented 1 year ago

The cni-conf.json configmap in kube-flannel-rbac.yml does not contain the VNI and Port required for windows vxlan communication. This is added.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: UweErikMartin Once this PR has been reviewed and has the lgtm label, please assign aravindhp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
linux-foundation-easycla[bot] commented 1 year ago

CLA Missing ID CLA Not Signed

jsturtevant commented 1 year ago

It looks like the first few commits are missing info:

❌ The commit (https://github.com/kubernetes-sigs/sig-windows-tools/commit/f0487def315349c5450da9adfd394586942d0719, https://github.com/kubernetes-sigs/sig-windows-tools/commit/697a097f98908ea8230695a22b7a420bd5c95cd8). This user is missing the User's ID, preventing the EasyCLA check. [Consult GitHub Help](https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user) to resolve.For further assistance with EasyCLA, [please submit a support request ticket](https://jira.linuxfoundation.org/servicedesk/customer/portal/4).

Maybe if you sqaush the commits, drop them or start fresh it might help? The latest commits seems to have the correct info

UweErikMartin commented 1 year ago

/check-cla

UweErikMartin commented 1 year ago

I start from scratch