search

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
126 stars 123 forks source link

Push new images to docker hub #317

Closed Mik4sa closed 7 months ago

Mik4sa commented 1 year ago

Describe the bug The images, atleast for flannel and kube-proxy, are outdated (see https://github.com/kubernetes-sigs/sig-windows-tools/pull/308#issuecomment-1551110003 and #316). We should push a new version to docker hub.

Also I feel like we should add an action to automatically push new Versions. Do you agree?

jonaskello commented 1 year ago

I'm also looking for new flannel images but cannot find any.

Is the workaround to build them yourself for now?

Mik4sa commented 1 year ago

See https://github.com/kubernetes-sigs/sig-windows-tools/issues/336#issuecomment-1633854019

To build your own images prepare a docker installation powered by linux containers on a windows system. Execute this command to create the builder needed to build flannel and kube-proxy:

docker buildx create --name img-builder --use --platform windows/amd64

Afterwars clone this repo and checkout the master branch. Open this folder in a terminal /hostprocess/flannel/flanneld. Set $flannelVersion and $repository accordingly. I used for example $flannelVersion="v0.21.5" and $repository="mik4sa". Last but not least execute this command to build and push your image:

docker buildx build --provenance=false --sbom=false --platform windows/amd64 --output=type=registry --pull --build-arg=flannelVersion=$flannelVersion -f Dockerfile -t $repository/flannel:$flannelVersion-hostprocess .

Next open this folder in a terminal /hostprocess/flannel/kube-proxy. Set $proxyVersion and $repository accordingly. I used for example $proxyVersion="v1.27.1" and $repository="mik4sa". Last but not least execute this command to build and push your image:

docker buildx build --provenance=false --sbom=false --platform windows/amd64 --output=type=registry --pull --build-arg=k8sVersion=$proxyVersion -f Dockerfile -t $repository/kube-proxy:$proxyVersion-flannel-hostprocess .

In the manifest you apply, so flannel-overlay.yml and kube-proxy.yml you need to reference the image you just created. So change image: sigwindowstools/[...] to image: mik4sa/[...]

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 7 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/sig-windows-tools/issues/317#issuecomment-2019132106): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.