Add option to override the hostname for kubeadm

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.

Apache License 2.0

126 stars 123 forks source link

Add option to override the hostname for kubeadm #321

Closed djboris9 closed 1 year ago

djboris9 commented 1 year ago

Reason for PR: The hostname command returns the local node name whereas people might wish to use the FQDN or some other alternative domain name for the kubelet. This PR allows the user to specify an overridden hostname for kubeadm while having the default still set to the value returned by hostname.

Issue Fixed: No issue created

Requirements

[X] Sqaush commits
[ ] Documentation
[ ] Tests

Notes:

jsturtevant commented 1 year ago

/lgtm

jsturtevant commented 1 year ago

I am going to approve this but please note that hostnames that are longer than 15 characters can have compatibility issues: https://github.com/kubernetes-sigs/cluster-api/issues/2217

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djboris9, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)~~ [jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment