search

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
123 stars 123 forks source link

Improvements to InstallContainerd.ps1 and PrepareNode.ps1 #325

Closed coutinhop closed 1 year ago

coutinhop commented 1 year ago

(from the Calico forks on https://docs.tigera.io/calico/3.26/scripts/PrepareNode.ps1 and https://docs.tigera.io/calico/3.26/scripts/Install-Containerd.ps1)

InstallContainerd.ps1:

PrepareNode.ps1:

Reason for PR:

Issue Fixed:

Issue #

Requirements

Notes:

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 year ago

Welcome @coutinhop!

It looks like this is your first PR to kubernetes-sigs/sig-windows-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-windows-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

jsturtevant commented 1 year ago

/lgtm /assign @Mik4sa

k8s-ci-robot commented 1 year ago

@jsturtevant: GitHub didn't allow me to assign the following users: Mik4sa.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/sig-windows-tools/pull/325#issuecomment-1571104904): >/lgtm >/assign @Mik4sa Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Mik4sa commented 1 year ago

/assign

jsturtevant commented 1 year ago

the changes lgtm, @coutinhop did you want to update the docs to be clearer about the setup?

coutinhop commented 1 year ago

the changes lgtm, @coutinhop did you want to update the docs to be clearer about the setup?

Yes, will do! Apologies, had some personal issues keeping me busy, will do so right away

jsturtevant commented 1 year ago

/lgtm /hold for @Mik4sa to try it out

Mik4sa commented 1 year ago

@jsturtevant Everything good so far :) /hold cancel

jsturtevant commented 1 year ago

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coutinhop, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)~~ [jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment