Closed coutinhop closed 1 year ago
The committers listed above are authorized under a signed CLA.
Welcome @coutinhop!
It looks like this is your first PR to kubernetes-sigs/sig-windows-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/sig-windows-tools has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
/lgtm /assign @Mik4sa
@jsturtevant: GitHub didn't allow me to assign the following users: Mik4sa.
Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
/assign
the changes lgtm, @coutinhop did you want to update the docs to be clearer about the setup?
the changes lgtm, @coutinhop did you want to update the docs to be clearer about the setup?
Yes, will do! Apologies, had some personal issues keeping me busy, will do so right away
/lgtm /hold for @Mik4sa to try it out
@jsturtevant Everything good so far :) /hold cancel
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: coutinhop, jsturtevant
The full list of commands accepted by this bot can be found here.
The pull request process is described here
(from the Calico forks on https://docs.tigera.io/calico/3.26/scripts/PrepareNode.ps1 and https://docs.tigera.io/calico/3.26/scripts/Install-Containerd.ps1)
InstallContainerd.ps1:
PrepareNode.ps1:
Reason for PR:
Issue Fixed:
Issue #
Requirements
Notes: