search

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
123 stars 123 forks source link

Add crictl to Install-Containerd.ps1 #326

Closed Mik4sa closed 1 year ago

Mik4sa commented 1 year ago

Reason for PR: Adds crictl to Install-Containerd.ps1. kubeadm printed a warning if this is missing in %PATH%:

[preflight] Running pre-flight checks W0604 13:26:50.979201 948 checks.go:1064] [preflight] WARNING: Couldn't create the interface used for talking to the container runtime: crictl is required by the container runtime: executable file not found in %PATH%

crictl seems to be needed for some cleanup tasks when executing kubeadm reset. See https://github.com/kubernetes-sigs/sig-windows-tools/issues/281#issuecomment-1565425125

Issue Fixed: Fixes #281

Requirements

Notes: Thanks to @jonaskello for pointing this out and providing a solution to this.

jsturtevant commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, Mik4sa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)~~ [jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment