Closed davhdavh closed 4 months ago
Welcome @davhdavh!
It looks like this is your first PR to kubernetes-sigs/sig-windows-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/sig-windows-tools has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
I think these changes look good. I will enlist in the PR branch and check things out this week.
@davhdavh - Can you rebase this so it'll pick up some of the changes from https://github.com/kubernetes-sigs/sig-windows-tools/pull/331?
And also if this is switched to a host-process container we don't need to make or push a manifest so everything after the # Create manifest
line in the build.sh script should be removed.
thanks!
Hi @jayunit100, would you be so kind and review this dangling PR? Would be much appreciated. 😊
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: davhdavh, jsturtevant
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
merge it?
merge it?
Seems that there is a label missing:
Idk, who applies this label.
@jsturtevant I think it needs your approval
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/lgtm
Reason for PR: Change base image to windows-host-process-containers-base-image for minimal image size and compat with all windows versions in 1 image