search

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
123 stars 123 forks source link

use the windows-host-process-containers-base-image for minimal image size #329

Closed davhdavh closed 4 months ago

davhdavh commented 1 year ago

Reason for PR: Change base image to windows-host-process-containers-base-image for minimal image size and compat with all windows versions in 1 image

k8s-ci-robot commented 1 year ago

Welcome @davhdavh!

It looks like this is your first PR to kubernetes-sigs/sig-windows-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-windows-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

marosset commented 1 year ago

I think these changes look good. I will enlist in the PR branch and check things out this week.

marosset commented 1 year ago

@davhdavh - Can you rebase this so it'll pick up some of the changes from https://github.com/kubernetes-sigs/sig-windows-tools/pull/331?

And also if this is switched to a host-process container we don't need to make or push a manifest so everything after the # Create manifest line in the build.sh script should be removed.

thanks!

jgrieger commented 11 months ago

Hi @jayunit100, would you be so kind and review this dangling PR? Would be much appreciated. 😊

jsturtevant commented 10 months ago

/approve

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davhdavh, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)~~ [jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jgrieger commented 7 months ago

/remove-lifecycle stale

davhdavh commented 7 months ago

merge it?

jgrieger commented 7 months ago

merge it?

Seems that there is a label missing: image

Idk, who applies this label.

davhdavh commented 7 months ago

@jsturtevant I think it needs your approval

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jsturtevant commented 4 months ago

/lgtm