kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
123 stars 123 forks source link

Update to build latest csi proxy #330

Closed davhdavh closed 1 year ago

davhdavh commented 1 year ago

Reason for PR: Update to latest csi proxy version

jsturtevant commented 1 year ago

/lgtm /assign @marosset

marosset commented 1 year ago

@davhdavh - Can you bump https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/hostprocess/csi-proxy/VERSION too? This is read by the github action workflow to set the image tag. https://github.com/kubernetes-sigs/sig-windows-tools/blob/8f6578afa481edc0daf358709919d2a74c5876b2/.github/workflows/csi-proxy.yml#L35-L40

otherwise LGTM

marosset commented 1 year ago

/lgtm /approve

thanks @davhdavh!

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davhdavh, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)~~ [marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
marosset commented 1 year ago

@davhdavh - a v1.1.2 image is available at https://github.com/kubernetes-sigs/sig-windows-tools/pkgs/container/sig-windows%2Fcsi-proxy/103507027?tag=v1.1.2

davhdavh commented 1 year ago

Thanks

On Thu, Jun 22, 2023 at 12:32 AM Mark Rossetti @.***> wrote:

@davhdavh https://github.com/davhdavh - a v1.1.2 image is available at https://github.com/kubernetes-sigs/sig-windows-tools/pkgs/container/sig-windows%2Fcsi-proxy/103507027?tag=v1.1.2

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/sig-windows-tools/pull/330#issuecomment-1601292915, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJFIDPXDJQWQWOS7V6PA7LXMMVZZANCNFSM6AAAAAAZEJ6M4Q . You are receiving this because you were mentioned.Message ID: @.***>

-- Dennis