kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
123 stars 123 forks source link

fixing csi-proxy manifest-list builds #331

Closed marosset closed 1 year ago

marosset commented 1 year ago

Reason for PR:

I built and pushed https://hub.docker.com/layers/mrosse3/csi-proxy/v1.1.2/images/sha256-94f8de9302bb607a9d1955870aa9b180333bb8e767f31341181625b0a8386b51?context=repo with these changes

Issue Fixed:

Issue #

Requirements

Notes:

/sig windows /assign @jsturtevant @davhdavh

k8s-ci-robot commented 1 year ago

@marosset: GitHub didn't allow me to assign the following users: davhdavh.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/sig-windows-tools/pull/331): >**Reason for PR**: > >- Bumping golang version from `v1.16` to `v1.20` >- Fixing issue with building the image manifest (buildkit 10.x creates manifest-lists with SBOM info unless you specify --sbom=false and this breaks the build script) > > >I built and pushed https://hub.docker.com/layers/mrosse3/csi-proxy/v1.1.2/images/sha256-94f8de9302bb607a9d1955870aa9b180333bb8e767f31341181625b0a8386b51?context=repo with these changes > >**Issue Fixed**: > >Issue # > >**Requirements** > >- [x] Sqaush commits >- [ ] Documentation >- [ ] Tests > >**Notes**: > >/sig windows >/assign @jsturtevant @davhdavh > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jsturtevant commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)~~ [jsturtevant,marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment