search

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
123 stars 123 forks source link

Fix kube-proxy start.ps1 #342

Closed lzhecheng closed 1 year ago

lzhecheng commented 1 year ago

Reason for PR:

Fix kube-proxy start.ps1. To avoid ConfigMap mount reset, a copy of kubeconfig.conf should be used as kube-proxy.exe's arg.

Issue Fixed:

Issue #341

Requirements

Notes:

lzhecheng commented 1 year ago

/cc @jsturtevant

jsturtevant commented 1 year ago

/lgtm /assign @marosset

marosset commented 1 year ago

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)~~ [marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment