search

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
123 stars 123 forks source link

Documentation points to image that doesn't exist yet #343

Closed MarkBoote closed 5 months ago

MarkBoote commented 1 year ago

Describe the bug Trying to update our windows nodes following the instructions at https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/guides/flannel.md

To Reproduce controlPlaneEndpoint=$(kubectl get configmap -n kube-system kube-proxy -o jsonpath="{.data['kubeconfig.conf']}" | grep server: | sed 's/.*\:\/\///g') kubernetesServiceHost=$(echo $controlPlaneEndpoint | cut -d ":" -f 1) kubernetesServicePort=$(echo $controlPlaneEndpoint | cut -d ":" -f 2) curl -L https://raw.githubusercontent.com/kubernetes-sigs/sig-windows-tools/master/hostprocess/flannel/flanneld/flannel-overlay.yml | sed 's/FLANNEL_VERSION/v0.21.5/g' | sed "s/KUBERNETES_SERVICE_HOST_VALUE/$kubernetesServiceHost/g" | sed "s/KUBERNETES_SERVICE_PORT_VALUE/$kubernetesServicePort/g" | kubectl apply -f -

Expected behavior Kind of hope https://hub.docker.com/r/sigwindowstools/flannel/tags?page=1&name=v0.21.5 would actually exist, what with it being referenced in the documentation.

Kubernetes (please complete the following information):

Additional context Just once it would be nice to be able to upgrade flannel on 'doze without tearing my hair out.

Mik4sa commented 1 year ago

Please build your own image, see https://github.com/kubernetes-sigs/sig-windows-tools/issues/336#issuecomment-1633854019

MarkBoote commented 1 year ago

Please build your own image, see #336 (comment)

Built my own image, but still had problems starting flannel on windows.

W0829 17:10:51.499936 3824 client_config.go:617] Neither --kubeconfig nor --master was specified. Using the inClusterConfig. This might not work. W0829 17:10:51.520129 3824 client_config.go:622] error creating inClusterConfig, falling back to default config: open /var/run/secrets/kubernetes.io/serviceaccount/token: The system cannot find the path specified. E0829 17:10:51.531215 3824 main.go:228] Failed to create SubnetManager: fail to create kubernetes config: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

This turns out to be an issue with containerd.

Existing cluster was running containerd 1.6.22, which gives the above error. I did try updating to 1.7.5, but bumped into issues with flannel getting 'Access Denied' to the etc & opt folders.

Built a lab cluster to reproduce, stopping containerd service, deleting program files/containerd, /etc & /opt folders then installing containerd 1.7.1, everything seems to start without problems.

Might be worth making a note in the docs that latest will NOT work with containerd < 1.7.

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 5 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/sig-windows-tools/issues/343#issuecomment-2022757464): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.