search

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
123 stars 123 forks source link

Add directory of wmic.exe to path as required by csi-proxy #359

Closed laozc closed 7 months ago

laozc commented 7 months ago

Reason for PR: Fixes wmic.exe not found during CSI driver registration.

I0131 16:03:31.383613    6684 main.go:121] Received NotifyRegistrationStatus call: &RegistrationStatus{PluginRegistered:false,Error:RegisterPlugin error -- plugin registration failed with err: rpc error: code = Internal desc = failed to get system uuid for node VM with error: rpc error: code = Unknown desc = exec: "wmic": executable file not found in %PATH%,}
E0131 16:03:31.383613    6684 main.go:123] Registration process failed with error: RegisterPlugin error -- plugin registration failed with err: rpc error: code = Internal desc = failed to get system uuid for node VM with error: rpc error: code = Unknown desc = exec: "wmic": executable file not found in %PATH%, restarting registration container.

https://github.com/kubernetes-csi/csi-proxy/blob/07be14dabebca5d1590e670f9a796fcfce44d6e6/pkg/os/system/api.go#L37

Issue Fixed: Issue #358

Requirements

Notes:

aravindhp commented 7 months ago

/assign @jsturtevant @marosset

for approval

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, laozc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/OWNERS)~~ [jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment