search

kubernetes-sigs / sig-windows-tools

Repository for tools and artifacts related to the sig-windows charter in Kubernetes. Scripts to assist kubeadm and wincat and flannel will be hosted here.
Apache License 2.0
123 stars 123 forks source link

Release up-to-date sigwindowstools images #367

Open jjmilburn opened 3 months ago

jjmilburn commented 3 months ago

Is your feature request related to a problem? Please describe.

The images from Dockerhub that are used by the guides for Flannel in this repo appear to be out of sync with the files on the master branch here. This leads to errors related to path mismatches, e.g. the resulting script running in the pod looks for C:\hpc which does not exist.

The Windows instance is communicating to the cluster fine (shows up in kubectl, and is ready - pods are able to be assigned to it). But, the daemonset to set up Flannel fails (as does the kube-proxy one).

This is true for Containerd versions 1.7.17 and 1.7.1 on the host (Windows Server 2019).

The problem seems to be that this file: https://raw.githubusercontent.com/kubernetes-sigs/sig-windows-tools/master/hostprocess/flannel/flanneld/flannel-overlay.yml tries to pull sig-windows-tool images for flannel-hostprocess that were built quite a while ago, and don't line up with the current code in this repo.

Describe the solution you'd like Someone following the sig-windows-tools official guide for setting up Flannel to have a working flannel configuration.

Describe alternatives you've considered

Manually installing flanneld and kube-proxy on the host without a daemonset.

Additional context

jjmilburn commented 3 months ago

I have confirmed that building the image myself locally, and pushing it to Dockerhub, then modifying the CRD to refer to that image - works:

https://hub.docker.com/repository/docker/jjmilburn/flannel/general

The bot that builds images appears to be failing on the flannel side here.

jjmilburn commented 3 months ago

Confirmed that this deploys successfully using the image built here: https://hub.docker.com/layers/jjmilburn/flannel/v0.22.1-hostprocess/images/sha256-e02b91da766725b37898dc7fc8eaad9aed2eb8521bebf0d1db5a1fa718bad530?context=repo

We could resolve this issue by fixing the build pipelines for the Flannel HPC image, I do not have access to the ones owned by the SIG here.

Varorbc commented 1 month ago

@jjmilburn I have to build an flannel image on both Windows and Linux, but both have failed. Can you please tell me how to build an flannel image? Thank you.