Calico sometimes get the error "Set-Content: Stream was not readable" when calico-install.ps1 script runs

[oingooing]

Describe the bug When calico pod restarted, Sometimes the node status changes to "NotReady" because "calico-install.ps1" execution fail

To Reproduce

• restart a calico pod, sometimes the node's status remains NotReady.
• The Error "cni plugin not initialized" is recorded in the kubelet.err file.
  • "Container runtime network not ready" networkReady="NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: cni plugin not initialized"
• C:\etc\cni\net.d\10-calico.conflist file is empty!
• The Error "Set-Content: Stream was not readable" is recorded in the calico install-cni container log.
  • 2024-07-09T16:52:38.1806101+09:00 stderr F Set-Content : Stream was not readable. 2024-07-09T16:52:38.1806101+09:00 stderr F + ... :CNI_MTU) | Set-Content "${env:CNI_CONF_DIR}/10-calico.conflist" -For ... 2024-07-09T16:52:38.1806101+09:00 stderr F + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2024-07-09T16:52:38.183765+09:00 stderr F + CategoryInfo : InvalidArgument: (C:\etc\cni\net.d\10-calico.conflist:String) [Set-Content], ArgumentExc 2024-07-09T16:52:38.1826068+09:00 stdout F CNI configured 2024-07-09T16:52:38.183765+09:00 stderr F eption 2024-07-09T16:52:38.183765+09:00 stderr F + FullyQualifiedErrorId : GetContentWriterArgumentError,Microsoft.PowerShell.Commands.SetContentCommand 2024-07-09T16:52:38.183765+09:00 stderr F
• The execution of "calico-install.ps1" failed. However, the calico pod is in Running.

Expected behavior When calico is restarted, initialization should be completed normally.

Kubernetes (please complete the following information):

• Windows Server version: windows server 2022 21H2 version build 20348.2322
• Kubernetes Version: v1.26.6
• CNI: Calico v3.25.1

Additional context Should we put a short Start-Sleep before Set-Content? A file lock that has not cleared is my first guess at the cause.

[oingooing]

I found the cause.

I opened the /calico/install.ps1 script in the sigwindowstools/calico-install:v3.25.1-hostprocess image, the install.ps1 script was incorrect. Without deleting the $env:CNI_CONF_DIR directory $env:CNI_BIN_DIR Directory removal syntax is redundant. Maybe the wrong script was built a while back.

[wrong]

Write-Host "Starting install. Cleaning up any previous files"
Remove-Item -Path $env:CNI_BIN_DIR/* -Recurse
Remove-Item -Path $env:CNI_BIN_DIR/* -Recurse

[expect]

Write-Host "Starting install. Cleaning up any previous files"
Remove-Item -Path $env:CNI_BIN_DIR/* -Recurse
Remove-Item -Path $env:CNI_CONF_DIR/* -Recurse

I will build the image myself and use it.