kubernetes-sigs / slack-infra

Tooling for kubernetes.slack.com
Apache License 2.0
90 stars 36 forks source link

add bentheelder to reviewers #22

Closed BenTheElder closed 4 years ago

BenTheElder commented 4 years ago

I've reviewed a few PRs before, I'd like to help review more.

k8s-ci-robot commented 4 years ago

Welcome @BenTheElder!

It looks like this is your first PR to kubernetes-sigs/slack-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/slack-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

BenTheElder commented 4 years ago

/assign @Katharine

BenTheElder commented 4 years ago

@Katharine I don't think github approve == lgtm + approve is turned on in this repo.

Katharine commented 4 years ago

why have we still not turned this on everywhere :roll_eyes:

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/slack-infra/blob/master/OWNERS)~~ [Katharine] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment