kubernetes-sigs / slack-infra

Tooling for kubernetes.slack.com
Apache License 2.0
90 stars 36 forks source link

Adding a new app to post announcements #35

Closed rajula96reddy closed 4 years ago

rajula96reddy commented 4 years ago

This PR adds a new Slack application which enables users to post messages/ announcements to multiple channel(s). The message will be posted by the bot, on behalf of the user

Features:

Resolves

CC: @jonasrosland @mbbroberg @parispittman @mrbobbytables

k8s-ci-robot commented 4 years ago

Welcome @rajula96reddy!

It looks like this is your first PR to kubernetes-sigs/slack-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/slack-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 4 years ago

Hi @rajula96reddy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mbbroberg commented 4 years ago

Great to see this going @rajula96reddy! I don't know enough Go to be a code reviewer, but I'm here if I can be helpful. Maybe you can demo this at tomorrow's team meeting.

mbbroberg commented 4 years ago

@mrbobbytables, would you know who is best to review this? Thanks!

jeefy commented 4 years ago

/ok-to-test

mbbroberg commented 4 years ago

Awesome, thank you for the PR review @jeefy and updates @rajula96reddy. Ping me if I can help with anything to get this approved.

mrbobbytables commented 4 years ago

/assign @phumberdroz

k8s-ci-robot commented 4 years ago

@mrbobbytables: GitHub didn't allow me to assign the following users: phumberdroz.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/slack-infra/pull/35#issuecomment-682698045): >/assign @phumberdroz Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phumberdroz commented 4 years ago

/assign @phumberdroz

jeefy commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy, phumberdroz, rajula96reddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/slack-infra/blob/master/OWNERS)~~ [jeefy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mbbroberg commented 4 years ago

/lgtm

mbbroberg commented 4 years ago

Thanks @jeefy and @phumberdroz!