search

kubernetes-sigs / slack-infra

Tooling for kubernetes.slack.com
Apache License 2.0
90 stars 36 forks source link

Move to slack's new conversations API #37

Closed castrojo closed 3 years ago

castrojo commented 4 years ago

From Katharine in slack: Apparently the welcomer bot uses a deprecated API, nothing else does , looks like it’s just this line that needs changing:

https://github.com/kubernetes-sigs/slack-infra/blob/master/slack-welcomer/handler.go#L133

mrbobbytables commented 3 years ago

Here is the deprecation information https://api.slack.com/changelog/2020-01-deprecating-antecedents-to-the-conversations-api

palnabarun commented 3 years ago

@castrojo @mrbobbytables -- Can I take this up? :)

phumberdroz commented 3 years ago

Of course you can @palnabarun :)

mrbobbytables commented 3 years ago

cc @pymander He was interested in helping too :)

pymander commented 3 years ago

It looks like a pretty simple change, and I am happy to let @palnabarun take it.

palnabarun commented 3 years ago

@pymander @mrbobbytables -- I took a dig at it last weekend. The change needed is indeed simple.

I am wondering if there is a way I can test the change without setting up the whole bot in a new Slack workspace like described in docs/app-creation.md. What do you think?

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

fejta-bot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

k8s-ci-robot commented 3 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/slack-infra/issues/37#issuecomment-815147265): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.