search

kubernetes-sigs / slack-infra

Tooling for kubernetes.slack.com
Apache License 2.0
90 stars 36 forks source link

Replace Slack im API with conversations API #39

Closed palnabarun closed 2 years ago

palnabarun commented 4 years ago

Fixes #37

Deprecation Notice: https://api.slack.com/changelog/2020-01-deprecating-antecedents-to-the-conversations-api

Old API: https://api.slack.com/methods/im.open New API: https://api.slack.com/methods/conversations.open

The API method which got deprecated is im.open. The method (conversations.open) which replaces it also changes the request parameters required.

The deprecated API (im.open) required a request parameter called user whose value was the Slack user ID of the user that we intend to open a message channel with.

The new API method (conversations.open) provisions for the request parameter users which whose value needs to be a comma-separated list of up to 8 user IDs with whom we intend to start a conversation.

Signed-off-by: Nabarun Pal pal.nabarun95@gmail.com

palnabarun commented 4 years ago

/hold

I want to test it End to End. On the unit test side of things, I was wondering if I could wire up something.

jeefy commented 4 years ago

Well that was easy enough. :joy:

/approve

What are you planning e2e-wise?

palnabarun commented 4 years ago

Well that was easy enough. :joy:

Yeah. The API change was pretty simple. Only one endpoint and one request parameter change were needed. 😅

What are you planning e2e-wise?

I was wondering if there is a way I can test the change without setting up the bot in a new Slack workspace like described in docs/app-creation.md.

jeefy commented 4 years ago

You should be able to! If need be I can toss a slack workspace your way if you don't want to create one yourself.

palnabarun commented 4 years ago

@jeefy -- I set up a Slack workspace to experiment with. Will post updates on testing shortly.

jeefy commented 4 years ago

👍 👍 👍

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

irvifa commented 3 years ago

/remove-lifecycle stale

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

mrbobbytables commented 3 years ago

/remove-lifecycle stale @palnabarun did you know if it worked? If yes, we should merge this sooner rather than later 😬

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

jeefy commented 3 years ago

/remove-lifecycle rotten /approve /lgtm /hold @palnabarun Can you confirm this worked in the slack workspace you tested it in? I know it's been a while lol

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/slack-infra/blob/main/OWNERS)~~ [jeefy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

coderanger commented 2 years ago

Does this still need more testing?

/remove-lifecycle stale

jeefy commented 2 years ago

/hold cancel

Let's finally get this merged in and if there are issues we can revert to a prior image.