search

kubernetes-sigs / slack-infra

Tooling for kubernetes.slack.com
Apache License 2.0
90 stars 36 forks source link

slack: fix error check #42

Closed cpanato closed 3 years ago

cpanato commented 3 years ago

while working on https://github.com/kubernetes-sigs/slack-infra/pull/41 notice the check-in the fix might be another one :)

checking the err from the conversion the header was already validated a few lines above

/assign @BenTheElder @nikhita

cpanato commented 3 years ago

gently ping @jeefy to close the loop :)

jeefy commented 3 years ago

I appreciate the gentle ping ;) Feel free to ping me on Slack if a notification goes into /dev/null :joy:

jeefy commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jeefy, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/slack-infra/blob/master/OWNERS)~~ [jeefy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment