Closed spiffxp closed 3 years ago
+1 from github management team hat on
I've been updating description as I go. Dropped TODO's on what remains. I'm going to try and update k/community docs before closing this out. I'll post further updates as comments, not just description edits
Opened https://github.com/kubernetes/community/pull/5687 and https://github.com/kubernetes/test-infra/pull/21617 to close out the actual rename part of this, leaving notification, and then updating the branch rename docs as a followup
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale
/remove-lifecycle stale
/close Mailing list notification sent: https://groups.google.com/g/kubernetes-sig-contribex/c/rRnvJh2WROc/m/acEQqPODAQAJ
No remaining references to the old branch: https://cs.k8s.io/?q=slack-infra.*master&i=nope&files=&excludeFiles=&repos=
@spiffxp: Closing this issue.
Part of umbrella issue to rename default branches: https://github.com/kubernetes/org/issues/2222
Copy-pasted checklist from https://raw.githubusercontent.com/kubernetes/community/master/github-management/default-branch-migration.md
Changes pre-rename
Make the following changes before renaming the branch the
master
branch.Note: There might be additional changes required that have not been covered in this checklist.
Anytime
These changes are non-disruptive and can be made anytime before renaming the branch.
[x] If a prowjob triggers on the
master
branch (branches
field of the prowjob), add themain
branch to the list (see [kubernetes/test-infra#20665] for an example).[x] If the [
milestone_applier
] prow config references themaster
branch, add themain
branch to the config (see [kubernetes/test-infra#20675] for an example).[x] If the [
branch_protection
] prow config references themaster
branch, add themain
branch to the config.Just before rename
These changes are disruptive and should be made just before renaming the branch.
[x] If a prowjob mentions the
master
branch inbase_ref
, update it to themain
branch. For a periodic job, ensure that the branch is renamed between periodic job runs.[x] If a prowjob mentions
master
in its name, rename the job to to not include the branch name. [status-reconciler
] should automatically migrate the PR status contexts to the new job name but this has not been tested yet. The job with the new name will also appear as a differt job in Testgrid.[x] If a prowjob calls scripts or code in your repo that explicitly reference
master
, update all references to usemain
.[x] If the repo has netlify configured for it, ask a member of the GitHub Management Team to rename the
master
branch tomain
in the netlify site config. It can't be controlled through the netlify config in the repo.Approval
Rename the default branch
master
tomain
using the GitHub UI by following the [official instructions].Changes post-rename
After the default branch has been renamed to
main
, make the following changes.Note: There might be additional changes required that have not been covered in this checklist.
Prowjobs
master
branch in thebranches
field, remove themaster
branch (see [kubernetes/test-infra#20669] for an example).Prow config
[x] If the [
milestone_applier
] prow config references themaster
branch, remove it from the config.[x] If the [
branch_protection
] prow config references themaster
branch, remove it from the config.Other
[x] If any docs reference the
master
branch, update tomain
(URLs will be automatically redirected).[x] Ensure that CI and PR tests work fine.
[x] Trial the local development experience with a pre-rename clone.
[x] Send a notice about the branch rename to your SIG's mailing list. Include the link to the [GitHub instructions to rename your local branch].
/assign /sig contributor-experience /kind cleanup