Add test to show that typename and version don't always match

[apelisse]

The test is flaky since the behavior depends on the order of which the versions are processed, and the current code that prevents that from happening depends on an invalid name for the version.

To make sure you get the failure:

$ go test -run=TestVersionDoesntMatchTypename -count=10 ./merge/

[apelisse]

The bot failed, that's a good thing, it's supposed to :-)

[apelisse]

Unfortunately I couldn't really make the test non-flaky, maybe I should run it in a loop internally so it fails more often ... suggestions?

[lavalamp]

Yeah you could internally do 10 tries or something. Or you could fix the code 😅

[apelisse]

Yeah you could internally do 10 tries or something. Or you could fix the code 😅

I'll just do both ... :-)

[apelisse]

I've run the test a 100 times and it didn't flake!

[zqzten]

I've been busy this week, sorry😥. Thanks for fixing it for me, looks good!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, zqzten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/OWNERS)~~ [apelisse] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[zqzten]

@apelisse Apologize for bothering, I'm wondering why did this PR get closed? Is the version fix no longer needed?

[apelisse]

Wasn't this merged into another PR? I'll try to take a look.

[zqzten]

Nope, at least the fix is not in the upstream code so far.

[apelisse]

OK, this was a clean rebase on top of master, so none of this was indeed merged. Thanks!