Closed alexzielenski closed 2 years ago
/cc @Jefftree
Added tests, addressed comments.
tests added, newline removed ;)
/restest
I double checked the diff from that gofmt error. My checkout does not contain those changes. I tried to re-run gofmt locally but saw no changes. Not seeing the same thing on my side... Maybe the CI is confused?
It is expecting changes in comments replacing *
with -
/retest
Had typo in last attempt.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alexzielenski, lavalamp
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I suspect the schema change to pointer is backwards incompatible, I'll have to fix the tag and change the release branch to v5.
I removed the v4.2.2 tag since I think it was not correct semver.
Part of our solution for https://github.com/kubernetes/kubernetes/pull/110495
Adds necessary functionality to support field-level annotations which may override the annotation of the referred type.