kubernetes-sigs / structured-merge-diff

Test cases and implementation for "server-side apply"
Apache License 2.0
105 stars 62 forks source link

Add typename different from version test #228

Closed apelisse closed 2 years ago

apelisse commented 2 years ago

I can't re-open #219, so just re-creating this.

apelisse commented 2 years ago

/assign @lavalamp @zqzten

apelisse commented 2 years ago

Feel free to /lgtm this if you're fine with it @zqzten, thanks!

lavalamp commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, lavalamp, zqzten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/OWNERS)~~ [apelisse,lavalamp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment