search

kubernetes-sigs / structured-merge-diff

Test cases and implementation for "server-side apply"
Apache License 2.0
105 stars 62 forks source link

validation: Allow loose validation for sets #247

Closed apelisse closed 1 year ago

apelisse commented 1 year ago

If a set (or associative lists keys) has duplicated elements, then this will not fail the validation. Everything else is still the same.

/assign @alexzielenski

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/OWNERS)~~ [apelisse] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
apelisse commented 1 year ago

This is starting to address #234. I have all the code passing the numerous tests I've written, but I'm going to send small PRs. cc @thockin

alexzielenski commented 1 year ago

/hold

edit: whoops too late

apelisse commented 1 year ago

No worries, let me know what you want me to address, I'll focus on that before continuing.