Closed apelisse closed 11 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: apelisse
The full list of commands accepted by this bot can be found here.
The pull request process is described here
OK, I've added comments to explain what happens, hopefully that helps.
OK I've added a new commit to create a new map of PEs to interface{}
, and then updated the other commit to use it instead of value, which simplifies the code a tiny bit since we don't have to create the new valueinterface thingy.
/lgtm /hold
in case you wanted to change anything else
/hold
I'm good thanks!
I meant /hold cancel
Same strategy as #249, still trying to address #234. Algorithm goes as follow:
Rewording:
In compare, treat duplicate keys in associative lists/sets as a separate atomic list, marked by owning just the duplicated key.
/assign @alexzielenski /cc @jpbetz