search

kubernetes-sigs / structured-merge-diff

Test cases and implementation for "server-side apply"
Apache License 2.0
97 stars 58 forks source link

add `Set` to value interface for lists #252

Closed alexzielenski closed 11 months ago

alexzielenski commented 12 months ago

mirrors behavior of existing Set for maps

needed to write a Default function that applies schema defaults to a value.Value in Declarative Validation

/assign @apelisse

apelisse commented 12 months ago

I think that's fine, thanks /lgtm /approve

k8s-ci-robot commented 12 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, apelisse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/OWNERS)~~ [apelisse] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
apelisse commented 12 months ago

You need to fix a gofmt thingy.

k8s-ci-robot commented 12 months ago

New changes are detected. LGTM label has been removed.

k8s-ci-robot commented 12 months ago

@alexzielenski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-structured-merge-diff-test f8de3760702eec0ef6fedce0f90340ddb5a6799f link true /test pull-structured-merge-diff-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
apelisse commented 11 months ago

/close

I think we abandoned the idea.

k8s-ci-robot commented 11 months ago

@apelisse: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/structured-merge-diff/pull/252#issuecomment-1760347136): >/close > >I think we abandoned the idea. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.