kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
293 stars 177 forks source link

[E2E-Test-Fix]: Fixing NotAuthenticated issue in tests #2818

Closed rpanduranga closed 5 months ago

rpanduranga commented 5 months ago

What this PR does / why we need it:

Test: create volume snapshot when hostd goes down

Before Fix: fault: <*types.NotAuthenticated | 0xc00095a9b0>{

After Fix: 14:58:42 Ran 2 of 816 Specs in 2086.849 seconds 14:58:42 SUCCESS! -- 2 Passed | 0 Failed

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # NA

Testing done: YES

https://container-dp.svc.eng.vmware.com/job/csi-block-vanilla-precheckin/2691/ https://container-dp.svc.eng.vmware.com/job/csi-block-vanilla-precheckin/2690/ https://container-dp.svc.eng.vmware.com/job/csi-block-vanilla-precheckin/2689/ https://container-dp.svc.eng.vmware.com/job/csi-block-vanilla-precheckin/2688/ https://container-dp.svc.eng.vmware.com/job/csi-block-vanilla-precheckin/2683/

Special notes for your reviewer: NA

Release note: NA

k8s-ci-robot commented 5 months ago

Hi @rpanduranga. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kavyashree-r commented 5 months ago

/approve

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, rpanduranga, sashrith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/e2e/OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/OWNERS)~~ [kavyashree-r,sashrith] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kavyashree-r commented 5 months ago

/lgtm