search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
293 stars 177 forks source link

bump up govmomi to v0.36.1 #2821

Closed divyenpatel closed 5 months ago

divyenpatel commented 5 months ago

What this PR does / why we need it: bump up govmomi to v0.36.1

This is required to add support for SHA256 thumbprint based vCenter authentication. vSphere Config Secret used for Verification

[Global]
cluster-id = "cluster1"
cluster-distribution = "CSI-Vanilla"
thumbprint = "92:87:AE:0F:DE:87:E3:8E:94:F0:A6:E4:CF:A0:65:9F:20:8A:7F:26:44:C0:46:20:BF:82:ED:FD:40:D4:8F:C7"
insecure-flag = "false"

[VirtualCenter "vchost@domain.com"]
user = "Administrator@vsphere.local"
password = "password"
port = "443"
datacenters = "VSAN-DC"

Without this bumpup

2024-03-13T18:44:07.443Z    DEBUG   vsphere/virtualcenter.go:174    using thumbprint 92:87:AE:0F:DE:87:E3:8E:94:F0:A6:E4:CF:A0:65:9F:20:8A:7F:26:44:C0:46:20:BF:82:ED:FD:40:D4:8F:C7 for url sc2-10-43-167-220.nimbus.eng.vmware.com:443    {"TraceId": "83a871c7-9b51-47e7-98d3-fbaa58861f12"}
2024-03-13T18:44:07.443Z    DEBUG   vsphere/virtualcenter.go:178    Setting vCenter soap client timeout to 5m0s {"TraceId": "83a871c7-9b51-47e7-98d3-fbaa58861f12"}
2024-03-13T18:44:07.677Z    ERROR   vsphere/virtualcenter.go:181    failed to create new client with err: Post "https://sc2-10-43-167-220.nimbus.eng.vmware.com:443/sdk": host "sc2-10-43-167-220.nimbus.eng.vmware.com:443" thumbprint does not match "92:87:AE:0F:DE:87:E3:8E:94:F0:A6:E4:CF:A0:65:9F:20:8A:7F:26:44:C0:46:20:BF:82:ED:FD:40:D4:8F:C7"    {"TraceId": "83a871c7-9b51-47e7-98d3-fbaa58861f12"}
sigs.k8s.io/vsphere-csi-driver/v3/pkg/common/cns-lib/vsphere.(*VirtualCenter).NewClient
    /build/pkg/common/cns-lib/vsphere/virtualcenter.go:181
sigs.k8s.io/vsphere-csi-driver/v3/pkg/common/cns-lib/vsphere.(*VirtualCenter).connect
    /build/pkg/common/cns-lib/vsphere/virtualcenter.go:306
sigs.k8s.io/vsphere-csi-driver/v3/pkg/common/cns-lib/vsphere.(*VirtualCenter).Connect
    /build/pkg/common/cns-lib/vsphere/virtualcenter.go:270
sigs.k8s.io/vsphere-csi-driver/v3/pkg/common/cns-lib/vsphere.GetVirtualCenterInstanceForVCenterConfig
    /build/pkg/common/cns-lib/vsphere/virtualcenter.go:682
sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/vanilla.(*controller).Init
    /build/pkg/csi/service/vanilla/controller.go:216
sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service.(*vsphereCSIDriver).BeforeServe
    /build/pkg/csi/service/driver.go:188
sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service.(*vsphereCSIDriver).Run
    /build/pkg/csi/service/driver.go:202
main.main
    /build/cmd/vsphere-csi/main.go:96
runtime.main
    /usr/local/go/src/runtime/proc.go:267

With this bump up

2024-03-13T18:35:35.961Z    DEBUG   vsphere/virtualcenter.go:174    using thumbprint 92:87:AE:0F:DE:87:E3:8E:94:F0:A6:E4:CF:A0:65:9F:20:8A:7F:26:44:C0:46:20:BF:82:ED:FD:40:D4:8F:C7 for url sc2-10-43-167-220.nimbus.eng.vmware.com:443    {"TraceId": "c137f8df-9126-4197-bc72-13a02d8a722b"}
2024-03-13T18:35:35.962Z    DEBUG   vsphere/virtualcenter.go:178    Setting vCenter soap client timeout to 5m0s {"TraceId": "c137f8df-9126-4197-bc72-13a02d8a722b"}
2024-03-13T18:35:36.069Z    INFO    vsphere/virtualcenter.go:213    New session ID for 'VSPHERE.LOCAL\Administrator' = 52da7f22-10e4-41df-409d-c5e2871ec058 {"TraceId": "c137f8df-9126-4197-bc72-13a02d8a722b"}

Special notes for your reviewer:

Release note:

bump up govmomi to v0.36.1
SandeepPissay commented 5 months ago

Looks good. Thanks @divyenpatel !

As we discussed lets address this for multi vCenter deployments as well since the Thumbprint conf for CSI should be on a per vCenter basis.

/approve

SandeepPissay commented 5 months ago

@divyenpatel can you look into the 4 failure checks?

divyenpatel commented 5 months ago

/retest

divyenpatel commented 5 months ago

@divyenpatel can you look into the 4 failure checks?

Failed Tests can be ignored. They are coming from netlify which we were using for generating documentation for vSphere Driver. Since we have moved documentation out of this repository we can remove netlify deployment.

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel, SandeepPissay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/OWNERS)~~ [SandeepPissay,chethanv28,divyenpatel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment