search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
293 stars 177 forks source link

Revert "bump up govmomi to v0.36.1 (#2821)" #2824

Closed skogta closed 5 months ago

skogta commented 5 months ago

What this PR does / why we need it: This reverts commit bb2cbc2c2dfe3713aa8bc42fcb8a44d81232e69d.

It seems like as of govmomi 0.35.0, WaitForUpdates, WaitForResult and Wait have been deprecated. https://github.com/vmware/govmomi/commit/95aa2571dac212bfb067147a2bcf85b0eeb9afa6

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): make check is failing with:

tests/e2e/vsphere.go:1134:20: task.WaitForResult is deprecated: Please use WaitForResultEx instead.  (SA1019)
tests/e2e/vsphere.go:1282:19: task.WaitForResult is deprecated: Please use WaitForResultEx instead.  (SA1019)
tests/e2e/vsphere.go:1304:11: task.WaitForResult is deprecated: Please use WaitForResultEx instead.  (SA1019)
make: *** [staticcheck] Error 1

pkg/syncer/storagepool/listener.go:122:11: property.WaitForUpdates is deprecated: Please consider using WaitForUpdatesEx instead, as it does not create a new property collector, instead it destroys the property filter after the expected update is received.

Testing done: Make check passes without the govmomi upgrade commit.

Special notes for your reviewer:

Release note:

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skogta Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 5 months ago

Hi @skogta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
divyenpatel commented 5 months ago

Closing this PR as removing deprecated API usage with https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/2825