Closed skogta closed 5 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: skogta Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @skogta. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Closing this PR as removing deprecated API usage with https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/2825
What this PR does / why we need it: This reverts commit bb2cbc2c2dfe3713aa8bc42fcb8a44d81232e69d.
It seems like as of govmomi 0.35.0, WaitForUpdates, WaitForResult and Wait have been deprecated. https://github.com/vmware/govmomi/commit/95aa2571dac212bfb067147a2bcf85b0eeb9afa6
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): make check is failing with:Testing done: Make check passes without the govmomi upgrade commit.
Special notes for your reviewer:
Release note: