Closed adikul30 closed 5 months ago
cc: @divyenpatel @akutz @bryanv
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adikul30, akutz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
Relying on
networkinterfaces
kind for obtaining IP is not ideal as it's a spec internal to the VM spec and the naming convention has changed and can also change in the future. Following discussions at https://github.com/kubernetes-sigs/vsphere-csi-driver/discussions/2835, we should usevm.status.vmIp
instead. This will fix the issue in v1a1.Upgrading from v1a1 to v1a2 will be done in a follow up PR: https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/2831
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done: Pending
Special notes for your reviewer:
Release note: