search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
293 stars 177 forks source link

Fix GetTKGVMIP() logic in VDS for vm-op v1alpha1 #2838

Closed adikul30 closed 5 months ago

adikul30 commented 5 months ago

What this PR does / why we need it:

Relying on networkinterfaces kind for obtaining IP is not ideal as it's a spec internal to the VM spec and the naming convention has changed and can also change in the future. Following discussions at https://github.com/kubernetes-sigs/vsphere-csi-driver/discussions/2835, we should use vm.status.vmIp instead. This will fix the issue in v1a1.

Upgrading from v1a1 to v1a2 will be done in a follow up PR: https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/2831

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done: Pending

Special notes for your reviewer:

Release note:

adikul30 commented 5 months ago

cc: @divyenpatel @akutz @bryanv

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adikul30, akutz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/OWNERS)~~ [adikul30] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment