search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
293 stars 177 forks source link

Fix storageclass parameter name for storage policy ID in e2e testcases #2840

Closed akankshapanse closed 5 months ago

akankshapanse commented 5 months ago

What this PR does / why we need it: This PR fixes the incorrect storageclass parameter name for storage policy ID in e2e testcases from "StoragePolicyId" to "storagePolicyID". Due to this incorrect parameter, wcp pre-checking pipeline was failing with recent changes for storage quota evalution enabled due to PodVMOnStretchedSupervisor FSS enabled by default.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done: TBA

Special notes for your reviewer:

Release note:

Fix storageclass parameter name for storage policy ID in e2e testcases
k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akankshapanse Once this PR has been reviewed and has the lgtm label, please assign kavyashree-r for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[tests/e2e/OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akankshapanse commented 5 months ago

closing this PR as https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/2841 will be addressing the issue