kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
289 stars 173 forks source link

Remove listview-tasks feature gate #2851

Closed adikul30 closed 1 week ago

adikul30 commented 3 months ago

What this PR does / why we need it:

ListView FSS has been part of previous vanilla releases and has also been enabled on supervisor since some time. We can now remove this FSS.

As part of this change, we will reuse a single VC session throughout a container. This will reduce the number of VC sessions created by CSI.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:

### Vanilla

Build #2633 (Jul 10, 2024, 2:19:34 PM)
adkulkarni
PR 2851

Ran 1 of 877 Specs in 365.975 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 876 Skipped
PASS

Ginkgo ran 1 suite in 7m13.124314528s
Test Suite Passed
--
Ran 14 of 877 Specs in 12169.237 seconds
FAIL! -- 13 Passed | 1 Failed | 0 Pending | 863 Skipped
--- FAIL: TestE2E (12169.35s)
FAIL

Ginkgo ran 1 suite in 3h23m7.447861368s

### supervisor

Build #1470 (Jul 10, 2024, 6:07:17 PM)
adkulkarni
PR 2851
Ran 1 of 877 Specs in 278.803 seconds SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 876 Skipped PASS Ginkgo ran 1 suite in 6m4.450727696s Test Suite Passed make: Leaving directory `/home/worker/workspace/csi-wcp-precheckin/Results/1470/vsphere-csi-driver' 

Special notes for your reviewer:

Release note:

Remove listview-tasks feature gate
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adikul30

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/OWNERS)~~ [adikul30] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
adikul30 commented 1 week ago

cc: @divyenpatel, this PR can be merged.

divyenpatel commented 1 week ago

/ok-to-test

divyenpatel commented 1 week ago

/lgtm