Update Snapshot-specific CnsVolumeOperationDetails in CSI CreateSnapshot

nikhilbarge commented 3 months ago

What this PR does / why we need it: Update Snapshot-specific CnsVolumeOperationDetails in CSI CreateSnapshot, to deliver the extra params to the volmanager that creates the CnsVolumeOperationDetails.

Testing done: Run e2e test

Performed manual testing :

verified if snapshot created successfully with extra params :

{"level":"info","time":"2024-05-03T12:05:44.008990613Z","caller":"wcp/controller.go:1587","msg":"WCP CreateSnapshot: called with args {SourceVolumeId:ccd01548-20df-480e-82e5-3e5af5e307c4 Name:snapshot-ab0c8958-b1ba-4057-aa9b-fef97ba768cf Secrets:map[] Parameters:map[csi.storage.k8s.io/volumesnapshot/name:example-vanilla-rwo-filesystem-snapshot csi.storage.k8s.io/volumesnapshot/namespace:testsnap csi.storage.k8s.io/volumesnapshotcontent/name:snapcontent-ab0c8958-b1ba-4057-aa9b-fef97ba768cf] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}","TraceId":"f3240a6d-bbb0-4dff-9820-167fac9a26ea"}
.
.
{"level":"info","time":"2024-05-03T12:05:44.048301347Z","caller":"volume/manager.go:2355","msg":"QuotaInfo during CreateSnapshot call: {Reserved:1Gi StoragePolicyId: StorageClassName:example-vanilla-rwo-filesystem-sc Namespace:testsnap}","TraceId":"f3240a6d-bbb0-4dff-9820-167fac9a26ea"}
{"level":"info","time":"2024-05-03T12:05:44.065082432Z","caller":"volume/util.go:402","msg":"Calling CnsClient.CreateSnapshots: VolumeID [\"ccd01548-20df-480e-82e5-3e5af5e307c4\"] Description [\"snapshot-ab0c8958-b1ba-4057-aa9b-fef97ba768cf-ccd01548-20df-480e-82e5-3e5af5e307c4\"] cnsSnapshotCreateSpecList [[]types.CnsSnapshotCreateSpec{types.CnsSnapshotCreateSpec{DynamicData:types.DynamicData{}, VolumeId:types.CnsVolumeId{DynamicData:types.DynamicData{}, Id:\"ccd01548-20df-480e-82e5-3e5af5e307c4\"}, Description:\"snapshot-ab0c8958-b1ba-4057-aa9b-fef97ba768cf-ccd01548-20df-480e-82e5-3e5af5e307c4\"}}]","TraceId":"f3240a6d-bbb0-4dff-9820-167fac9a26ea"}
.
.
.
{"level":"info","time":"2024-05-03T12:05:47.739970348Z","caller":"wcp/controller.go:1671","msg":"CreateSnapshot succeeded for snapshot ccd01548-20df-480e-82e5-3e5af5e307c4+0647df87-84bb-48cd-ab2a-9476fc6cc347 on volume ccd01548-20df-480e-82e5-3e5af5e307c4 size 1073741824 Time proto seconds:1714737944 nanos:804338000 Timestamp 2024-05-03 12:05:44.804338 +0000 UTC Response: snapshot:<size_bytes:1073741824 snapshot_id:\"ccd01548-20df-480e-82e5-3e5af5e307c4+0647df87-84bb-48cd-ab2a-9476fc6cc347\" source_volume_id:\"ccd01548-20df-480e-82e5-3e5af5e307c4\" creation_time:<seconds:1714737944 nanos:804338000 > ready_to_use:true > ","TraceId":"f3240a6d-bbb0-4dff-9820-167fac9a26ea"}

Controller logs - vsphere_csi_controller.log

Snapshot log - snapshot_create.log

Special notes for your reviewer:

Release note:

Update Snapshot-specific CnsVolumeOperationDetails in CSI CreateSnapshot

k8s-ci-robot commented 3 months ago

Hi @nikhilbarge. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

svcbot-qecnsdp commented 3 months ago

Started vanilla Block pipeline... Build Number: 2567

svcbot-qecnsdp commented 3 months ago

Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
------------------------------

Ran 1 of 848 Specs in 393.820 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 847 Skipped
PASS

Ginkgo ran 1 suite in 7m45.081437662s
Test Suite Passed
--
------------------------------

Ran 14 of 848 Specs in 6894.830 seconds
SUCCESS! -- 14 Passed | 0 Failed | 0 Pending | 834 Skipped
PASS

Ginkgo ran 1 suite in 1h55m13.517907113s
Test Suite Passed
--

Ran 52 of 848 Specs in 1369.550 seconds
FAIL! -- 42 Passed | 10 Failed | 0 Pending | 796 Skipped

Ginkgo ran 1 suite in 23m10.313488886s

Test Suite Failed