Open akankshapanse opened 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: akankshapanse Once this PR has been reviewed and has the lgtm label, please assign divyenpatel for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
PR needs rebase.
please rebase this
What this PR does / why we need it: This PR adds reconciler for StoragePolicyQuota objects in syncer, which looks for add/delete events of StoragePolicyQuota CRs and accordingly creates StoragePolicyUsage CRs. Earlier this processing was managed by simple informer event in syncer (with handlers policyQuotaCRAdded() & policyQuotaCRDeleted()), however if these informer events get missed, the creation of StoragePolicyUsage CR does not happen again (given that full sync creates StoragePolicyUsage CR if the namespace has any bound/pending volumes, but if namespace does not have any PVC, no StoragePolicyUsage CR gets created in full sync today) Absense of StoragePolicyUsage CR blocks all further PVC/Snapshot creation/update. Hence it is necessary to reconcile/retry these event handling if missed/failed any time before.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done: Testing in progress. Will test the failure case or event miss case specifically and update logs
Tested basic storagepolicyquota add scenario on WCP setup
Special notes for your reviewer:
Release note: