search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
289 stars 173 forks source link

Increase csi-attacher worker threads to 100 for Supervisor #2890

Closed gohilankit closed 2 months ago

gohilankit commented 2 months ago

What this PR does / why we need it: This PR is increasing CSI attacher worker threads in Supervisor manifests to 100.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

CSI provisioner worker threads are set to 100 by default, but CSI attacher worker threads are set to only 25 for Supervisor. This results in volume provisioning at a faster rate but they can't be utilized in pods at the same rate. We should have same worker threads for create/delete and attach/detach operations.
We have seen issues during failure testing at scale that pods remained in ProviderFailed. Increasing the number of attacher threads have helped resolve such issues.

Testing done: Pre-checkin pipelines were run after changing the attacher threads. Most of the tests were successful except 2, which are not related to this change.

Release note:

Increase csi-attacher worker threads to 100 for Supervisor
adikul30 commented 2 months ago

/ok-to-test

deepakkinni commented 2 months ago

/approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakkinni, divyenpatel, gohilankit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/OWNERS)~~ [deepakkinni,divyenpatel,gohilankit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment