search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
296 stars 179 forks source link

test util fix for thumbprint auth #2894

Open rajguptavm opened 4 months ago

rajguptavm commented 4 months ago

What this PR does / why we need it: fix testcases for thumbprint based auth

Which issue this PR fixes (optional, in fixes #(, fixes #, ...) format, will close that issue when PR gets merged): fixes # Test fix for thumbprint based auth

Testing done: YES.

Special notes for your reviewer: @rpanduranga @sipriyaa @kavyashree-r @Aishwarya-Hebbar please review it.

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rajguptavm Once this PR has been reviewed and has the lgtm label, please assign sashrith for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[tests/e2e/OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 4 months ago

Hi @rajguptavm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
svcbot-qecnsdp commented 4 months ago

Started Vanilla block pre-checkin pipeline... Build Number: 11

svcbot-qecnsdp commented 4 months ago

Started Vanilla block pre-checkin pipeline... Build Number: 12

svcbot-qecnsdp commented 4 months ago 
Build ID: 12
Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 126 of 848 Specs in 36711.464 seconds
FAIL! -- 60 Passed | 66 Failed | 2 Flaked | 0 Pending | 722 Skipped
--- FAIL: TestE2E (36711.70s)
FAIL

Ginkgo ran 1 suite in 10h13m19.818499212s

Test Suite Failed
k8s-ci-robot commented 4 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 week ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten