kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
288 stars 173 forks source link

Update cnsvolumeinfo to hold aggregated snapshot size for pvc #2899

Closed nikhilbarge closed 6 days ago

nikhilbarge commented 1 month ago

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done: A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged. The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc. For new features, new tests should be done, in addition to regression tests. If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject. The review cycle will start, only after "[WIP]" is removed from the PR subject.

Special notes for your reviewer:

Release note:

k8s-ci-robot commented 1 month ago

Hi @nikhilbarge. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
svcbot-qecnsdp commented 1 month ago

Started vanilla Block pipeline... Build Number: 2599

svcbot-qecnsdp commented 1 month ago
Block vanilla build status: SUCCESS 
Stage before exit: finally 
svcbot-qecnsdp commented 4 weeks ago
Block vanilla build status: FAILURE 
Stage before exit: checkout 
svcbot-qecnsdp commented 4 weeks ago
Block vanilla build status: FAILURE 
Stage before exit: checkout 
svcbot-qecnsdp commented 4 weeks ago

Started vanilla file pipeline... Build Number: 1152

svcbot-qecnsdp commented 4 weeks ago
File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
svcbot-qecnsdp commented 3 weeks ago

Started vanilla Block pipeline... Build Number: 2614

svcbot-qecnsdp commented 3 weeks ago
Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
------------------------------

Ran 1 of 871 Specs in 406.039 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 870 Skipped
PASS

Ginkgo ran 1 suite in 7m48.382897399s
Test Suite Passed
--
Ran 14 of 871 Specs in 13332.835 seconds
FAIL! -- 13 Passed | 1 Failed | 3 Flaked | 0 Pending | 857 Skipped
--- FAIL: TestE2E (13332.93s)
FAIL

Ginkgo ran 1 suite in 3h42m30.130117246s

Test Suite Failed
svcbot-qecnsdp commented 3 weeks ago

Started Vanilla block pre-checkin pipeline... Build Number: 2832

svcbot-qecnsdp commented 3 weeks ago
Build ID: 2832
Block vanilla build status: SUCCESS 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
------------------------------

Ran 0 of 871 Specs in 0.020 seconds
SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 871 Skipped
PASS

Ginkgo ran 1 suite in 1m11.830072334s
Test Suite Passed
deepakkinni commented 2 weeks ago

/milestone "Storage Quota for Snapshots"

deepakkinni commented 2 weeks ago

/approve

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakkinni, nikhilbarge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/OWNERS)~~ [deepakkinni] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deepakkinni commented 6 days ago

/lgtm

deepakkinni commented 6 days ago

/ok-to-test

deepakkinni commented 6 days ago

/lgtm