kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
288 stars 173 forks source link

vc reboot fix #2905

Closed rajguptavm closed 1 month ago

rajguptavm commented 1 month ago

What this PR does / why we need it: fix testcases for vc reboot scenarios

Which issue this PR fixes (optional, in fixes #(, fixes #, ...) format, will close that issue when PR gets merged): fixes # Test fix for vc reboot scenarios

Testing done: YES. https://gist.github.com/rajguptavm/43eba1e4f6330d3866335671f81fc167

https://container-dp.svc.eng.vmware.com/job/csi-block-vanilla-precheckin/2799/console

@kavyashree-r @sipriyaa @rpanduranga Please review it.

k8s-ci-robot commented 1 month ago

Hi @rajguptavm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kavyashree-r commented 1 month ago

/approve /lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, rajguptavm, sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/e2e/OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/OWNERS)~~ [kavyashree-r] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment