search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
296 stars 179 forks source link

Updated storage quota extension service name #2907

Closed vdkotkar closed 4 months ago

vdkotkar commented 4 months ago

What this PR does / why we need it: Updated storage quota extension service name

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done: Testing completed with these changes on WCP setup.

Testing logs:

# kubectl describe storagepolicyquota -n quota-ns-10
Name:         wcpglobal-storage-profile-storagepolicyquota
Namespace:    quota-ns-10
Labels:       <none>
Annotations:  <none>
API Version:  cns.vmware.com/v1alpha1
Kind:         StoragePolicyQuota
Metadata:
  Creation Timestamp:  2024-06-05T10:07:00Z
  Generation:          1
  Resource Version:    13756183
  UID:                 e0a32c81-046e-48fe-8d03-f8d2761d172b
Spec:
  Limit:              9223372036854775807
  Storage Policy Id:  d241183b-3e4d-445a-be8a-ca15c753f68c
Status:
  Extensions:
    Extension Name:  cns-storage-quota-extension-service-volume
    Extension Quota Usage:
      Sc Quota Usage:
        Reserved:          0
        Used:              10Mi
      Storage Class Name:  wcpglobal-storage-profile
  Total:
    Sc Quota Usage:
      Reserved:          0
      Used:              10Mi
    Storage Class Name:  wcpglobal-storage-profile
Events:                  <none>

# kubectl describe storagepolicyusage -n quota-ns-10
Name:         wcpglobal-storage-profile-pvc-usage
Namespace:    quota-ns-10
Labels:       <none>
Annotations:  <none>
API Version:  cns.vmware.com/v1alpha1
Kind:         StoragePolicyUsage
Metadata:
  Creation Timestamp:  2024-06-05T10:07:00Z
  Generation:          3
  Resource Version:    13756182
  UID:                 0d596fb2-3345-41d7-8596-8fd5055fa07e
Spec:
  Resource API Group:       
  Resource Extension Name:  cns-storage-quota-extension-service-volume
  Resource Kind:            PersistentVolumeClaim
  Storage Class Name:       wcpglobal-storage-profile
  Storage Policy Id:        d241183b-3e4d-445a-be8a-ca15c753f68c
Status:
  Quota Usage:
    Reserved:  0
    Used:      10Mi
Events:        <none>

# k get pvc -n quota-ns-10
NAME                    STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                VOLUMEATTRIBUTESCLASS   AGE
example-raw-block-pvc   Bound    pvc-00c0b4c1-9dd1-484e-91fa-03f00d107ac5   10Mi       RWO            wcpglobal-storage-profile   <unset>                 10m

Special notes for your reviewer:

Release note:

Updated storage quota extension service name
k8s-ci-robot commented 4 months ago

Hi @vdkotkar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
xing-yang commented 4 months ago

/ok-to-test

xing-yang commented 4 months ago

Can you post testing results?

vdkotkar commented 4 months ago

Can you post testing results?

Added testing logs

akankshapanse commented 4 months ago

/approve

xing-yang commented 4 months ago

/approve /lgtm

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akankshapanse, vdkotkar, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment