kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
288 stars 173 forks source link

Topology usecases namespace creation code fix #2908

Closed sipriyaa closed 4 weeks ago

sipriyaa commented 1 month ago

What this PR does / why we need it: Topology usecases namespace creation code fix, along with rwx topology disruptive scenarios

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # Topology usecases namespace creation code fix

Testing done: Yes

topology-logs.txt

sipriya@C02CR8ENMD6M vsphere-csi-driver % golangci-lint run --enable=lll sipriya@C02CR8ENMD6M vsphere-csi-driver % make golangci-lint hack/check-golangci-lint.sh golangci/golangci-lint info checking GitHub for tag 'v1.57.2' golangci/golangci-lint info found version: 1.57.2 for v1.57.2/darwin/amd64 golangci/golangci-lint info installed /Users/sipriya/go/bin/golangci-lint INFO [config_reader] Config search paths: [./ /Users/sipriya/rwx-topology-set3/vsphere-csi-driver /Users/sipriya/rwx-topology-set3 /Users/sipriya /Users /] INFO [config_reader] Used config file .golangci.yml INFO [lintersdb] Active 8 linters: [errcheck gosimple govet ineffassign lll misspell staticcheck unused]

k8s-ci-robot commented 1 month ago

Hi @sipriyaa. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kavyashree-r commented 1 month ago

/approve

kavyashree-r commented 1 month ago

/lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, rajguptavm, sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/e2e/OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/OWNERS)~~ [kavyashree-r] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kavyashree-r commented 1 month ago

/approved /lgtm

kavyashree-r commented 1 month ago

/lgtm