kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
288 stars 173 forks source link

Empty FSS flags should not be defaulted on vanilla clusters #2910

Open rikatz opened 1 month ago

rikatz commented 1 month ago

What this PR does / why we need it: This PR removes the defaulting of feature flags namespace and configmap flags when they are empty, not enforcing the need of the FSS flags on vanilla clusters

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done: TBD on running cluster

Special notes for your reviewer:

Release note:

FSS flags are not defaulted on vanilla clusters
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rikatz Once this PR has been reviewed and has the lgtm label, please assign adikul30 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment