search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
296 stars 179 forks source link

Namespace creation name fixes and rwx topology disruptive usecases #2915

Closed sipriyaa closed 3 months ago

sipriyaa commented 3 months ago

What this PR does / why we need it:

This PR fixes the topology namespace creation and include the usecases and utils for rwx topology disruptive test scenarios

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # This PR fixes the topology namespace creation and include the usecases and utils for rwx topology disruptive test scenarios

Testing done: Yes topology-logs.txt

Special notes for your reviewer:

sipriya@C02CR8ENMD6M vsphere-csi-driver % golangci-lint run --enable=lll --timeout=5m
sipriya@C02CR8ENMD6M vsphere-csi-driver % make golangci-lint hack/check-golangci-lint.sh golangci/golangci-lint info checking GitHub for tag 'v1.57.2' golangci/golangci-lint info found version: 1.57.2 for v1.57.2/darwin/amd64 golangci/golangci-lint info installed /Users/sipriya/go/bin/golangci-lint INFO [config_reader] Config search paths: [./ /Users/sipriya/rwx-topology-disruptive/vsphere-csi-driver /Users/sipriya/rwx-topology-disruptive /Users/sipriya /Users /] INFO [config_reader] Used config file .golangci.yml INFO [lintersdb] Active 8 linters: [errcheck gosimple govet ineffassign lll misspell staticcheck unused] INFO [loader] Go packages loading at mode 575 (deps|exports_file|files|imports|name|compiled_files|types_sizes) took 13.310563315s INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 374.436893ms INFO [linters_context/goanalysis] analyzers took 1m6.098301952s with top 10 stages: buildir: 22.442557794s, misspell: 3.939459615s, S1038: 3.893243573s, unused: 2.001135168s, S1039: 1.798582234s, lll: 1.476494914s, printf: 1.455352084s, SA1012: 1.454218189s, SA4030: 1.259125558s, SA1004: 1.219665509s INFO [runner] Issues before processing: 137, after processing: 0 INFO [runner] Processors filtering stat (out/in): skip_dirs: 137/137, cgo: 137/137, skip_files: 137/137, exclude-rules: 1/47, invalid_issue: 137/137, path_prettifier: 137/137, identifier_marker: 47/47, filename_unadjuster: 137/137, autogenerated_exclude: 47/137, exclude: 47/47, nolint: 0/1 INFO [runner] processing took 45.043577ms with stages: nolint: 23.083533ms, autogenerated_exclude: 19.830818ms, identifier_marker: 1.021511ms, path_prettifier: 700.786µs, skip_dirs: 203.231µs, exclude-rules: 164.536µs, cgo: 17.884µs, invalid_issue: 8.411µs, filename_unadjuster: 6.561µs, max_same_issues: 1.492µs, uniq_by_line: 805ns, diff: 590ns, skip_files: 452ns, max_from_linter: 451ns, fixer: 405ns, sort_results: 405ns, source_code: 380ns, exclude: 334ns, path_prefixer: 300ns, severity-rules: 261ns, max_per_file_from_linter: 235ns, path_shortener: 196ns INFO [runner] linters took 12.764504847s with stages: goanalysis_metalinter: 12.719182724s INFO File cache stats: 340 entries of total size 7.3MiB INFO Memory: 262 samples, avg is 646.6MB, max is 2964.1MB INFO Execution took 26.466224116s
sipriya@C02CR8ENMD6M vsphere-csi-driver %

kavyashree-r commented 3 months ago

/approved /lgtm

kavyashree-r commented 3 months ago

/approve /lgtm

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, rajguptavm, sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/e2e/OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/OWNERS)~~ [kavyashree-r] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment